Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Spaces visual fixes #5909

Merged
merged 5 commits into from
Apr 23, 2021
Merged

Conversation

robintown
Copy link
Member

Cut off long room names and align checkboxes in the add existing rooms dialog, and fix the invite button margin.

Before:

Screenshot_2021-04-22 Element Matrix(1)
Screenshot_2021-04-22 Element Toaq(2)

After:

Screenshot_2021-04-22 Element Matrix
Screenshot_2021-04-22 Element Toaq(1)

6082891 caused the space info and
invite buttons to have no separation when you are the only person in a
space, since the margin was set on the face pile, which may be absent.

Signed-off-by: Robin Townsend <robin@robin.town>
@t3chguy t3chguy self-requested a review April 22, 2021 16:12
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this is great and much appreciated, thanks

Signed-off-by: Robin Townsend <robin@robin.town>
Signed-off-by: Robin Townsend <robin@robin.town>
Signed-off-by: Robin Townsend <robin@robin.town>
@robintown robintown force-pushed the spaces-visual-fixes branch from 569413e to 3d7842d Compare April 23, 2021 14:27
@t3chguy
Copy link
Member

t3chguy commented Apr 23, 2021

Please avoid force pushing as it discards my review thus far.

@robintown
Copy link
Member Author

Ah, will do. Netlify is failing? 😕

@t3chguy
Copy link
Member

t3chguy commented Apr 23, 2021

You need to pull latest develop

@robintown
Copy link
Member Author

Should be good to go

@t3chguy
Copy link
Member

t3chguy commented Apr 23, 2021

Awesome, thanks for this!

@t3chguy t3chguy merged commit e088118 into matrix-org:develop Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants